Dune switch [do not merge]#13
Open
UnixJunkie wants to merge 20 commits intoocaml-community:masterfrom
Open
Conversation
plus add missing '|' on each first pattern matched
add missing '|' on first pattern matched
add missing '|' character on first pattern matched
renamed: common.mli -> src/common.mli renamed: ocaml.ml -> src/ocaml.ml renamed: ocaml.mli -> src/ocaml.mli renamed: pipeline.ml -> src/pipeline.ml renamed: pipeline.mli -> src/pipeline.mli renamed: std.ml -> src/std.ml renamed: utils.ml -> src/utils.ml renamed: utils.mli -> src/utils.mli
needed to make unused vars explicit
so that dune knows it must be installed
dune requirement, apparently, since from one module we create both an exe and a library
Collaborator
Author
|
related to #7 |
|
the errors are due to META getting installed as an empty file. dune installs the file, but only the Makefile populates it |
|
fix: rename META.in to META.ocamlscript.template since a version's not set anywhere, dune will generate one like v2.0.3-46-gbc58ce8-dirty, but it works. |
Collaborator
Author
|
you should ask to become the maintainer of this project to @mjambon
…On Sat, Dec 13, 2025 at 04:40 jrfondren ***@***.***> wrote:
*jrfondren* left a comment (ocaml-community/ocamlscript#13)
<#13 (comment)>
fix: rename META.in to META.ocamlscript.template
since a version's not set anywhere, dune will generate one like
v2.0.3-46-gbc58ce8-dirty, but it works.
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFUFAFCVGDWFLLEA3EQMJL4BOKB7AVCNFSM6AAAAACO5KWKHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBYHEYTMNBVGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
My commitment to OCaml isn't firm right now, so that's probably a bad idea. What I'd prefer is also a break from the current design:
|
|
@UnixJunkie got any feedback on https://github.com/jrfondren/thin-ocamlscript ? This loses calc.ml, and the result is #! /usr/bin/env -S thin-ocamlscript -package unix -linkpkg --
let () =
if Array.length Sys.argv <> 2 then (
Printf.printf "usage: %s <file>\n" Sys.argv.(0);
exit 1);
let file = Sys.argv.(1) in
try
Unix.access file [Unix.R_OK];
print_endline ("file exists: " ^ file)
with Unix.Unix_error (Unix.ENOENT, _, _) ->
print_endline ("file doesn't exist: " ^ file) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we do this, then it compiles with dune, but all the tests and examples fail like
Hence the [do not merge].